Share dialog files sidebar #18185
Share dialog files sidebar #18185
Conversation
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| (function() { | |||
| var TEMPLATE = | |||
| '<div>Owner: {{owner}}'; | |||
| '<div><span>Owner: {{owner}}</span>'; | |||
|
So this code piece continues to use core/ajax/share.php up to now - right? With moving this to the OCS Sharing API we have an issue as discussed in #17143 (comment) Should we build a files only share side bar within files_sharing and use files_sharing only? |
|
@jancborchardt @PVince81 @blizzz did we respect the share expiry for internal shares in the ui? No need to implement this right away - but we need to respect this in the UI design - THX |
@DeepDiver1975 this is the kind of decision that @schiesbn wanted to have with @rullzer at the conf. I personally would vote for having a files-only share dialog for now and extend it later to make it generic, not the other way around. But I think @blizzz was also for having a generic sharing mechanism. |
|
but talking about this at the conf is a bit late? We are building this now. furthermore - if I remember correctly - we wanted to have share.js untouched - right? Well - maybe I did miss some parts of the conversation 😢 |
|
I like to avoid to maintain two share dialogs and maintain and touch both of them any time we need to fix or extend it. Also, for know I just want to complete this work and have the share dialog integrated in sidebar for files. I prefer new features in a later pull request for not letting this one grow too big and consume too much time. |
well - from my pov share.js has to simply die. At least this is what we have been talking about @schiesbn @PVince81 @karlitschek Don't get me wrong I'm not saying we need to address this now ... but we better keep this in mind |
|
it will not receive improvements, but will be thinned out. |
ok - agreed - please make sure I'm with you when you talk 😉 |
|
@blizzz let me know if there’s anything to review interface-wise. The dialog itself doesn’t change in this iteration, it just moves to the sidebar, right? |
it is being reimplemented |
|
Which means it stays visually the same, yes. |
| * | ||
| * @param itemType | ||
| * @param itemSource | ||
| * @param callback |
There was a problem hiding this comment.
Make sure to document the callback vs no callback sync behavior
|
This should also be rebased to reflect the actions in the dropdown change in master. |
|
also note: the DetailsView and subviews are now backbone views. |
blizzz
force-pushed
the
share-dialog-files-sidebar
branch
from
4e927a3
to
17d007e
Compare
|
rebased |
|
💣 Test FAILed. 💣 |
| var view = this; | ||
|
|
||
| //FIXME: specific to reshares stuff | ||
| this.model.on('change', function() { |
There was a problem hiding this comment.
with a bit of luck "change:reshares" could work 😉
There was a problem hiding this comment.
yes, should be safe, thanks for the hint
Display share icon in file list row. Update share icon status when the sharing state changed.
Some events need preventing default like unshare, but setting permissions doesn't.
The sharing dialog has been moved to ShareDialogView
Only toggle the current row
PVince81
force-pushed
the
share-dialog-files-sidebar
branch
from
e64799f
to
e7e0cfe
Compare
|
Force-pushed. Let's hope CI will be kind this time. |
|
jsunit and phpunit on sqlite did succeed -> merge |
Share dialog files sidebar
|
Congratulations everybody ;-) This is awesome stuff. |
supposed to implement #17665
obsoletes #18078
TODO: ensure backwards compatibility with showDropDown()not neededcurrently this is based on files-rightsidebar
cc @PVince81